Login
Username:

Password:

Remember me



Lost Password?

Register now!
Main Menu
Who's Online
1 user(s) are online (1 user(s) are browsing Forum)

Members: 0
Guests: 1

more...
   All Posts (Marlon)


(1) 2 3 »


Re: Bounty system

Joined:
2016/8/9 0:17
From Sweden
Group:
Member
Posts: 27
Offline
Quote:

Kalamatee wrote:
I understand your view, but as said - there’s no one ‘prefered’ Versioning tool. I like GitHub, but it has legal ramifications that aren’t compatable with some aspects of developers by AROS.

Also from my own experience using git isn’t always that great, and when something goes wrong (which inevitably it does with something as large as AROS) - it can become very complicated to fix.

Yeah, I know. Everyone has their preferred tool. Same goes with everything. Git just feels like a more modern and efficient tool when working together, that's all. Is github really that strict when it comes to reverse engineering? I'm pretty sure I've seen a couple of reverse engineered projects on there.

Posted on: 5/14 9:32
Transfer the post to other applications Transfer


Re: Bounty system

Joined:
2016/8/9 0:17
From Sweden
Group:
Member
Posts: 27
Offline
Quote:

Kalamatee wrote:
Quote:

Marlon wrote:
Quote:

Kalamatee wrote:
You are aware there is a git mirror of the repo yes? The reason we have stuck with svn is because any of the other versioning tools developers ‘prefer to use’ support accessing svn, however they do not support each other.


I am aware of the git mirror, but you can't really do pull requests to a mirror, right? Which completely defeats the purpose of git. Or does the mirror work both ways?


Jason expressed that he would look at merging pull request when this was set up (diffs against the tree can be applied regardless of the used versioning tools) however his involvement in the project Is pretty much 0 these days due to his new employers rules.

Alright, thanks for clarification. I'm not trying to step on some toes. I just suggested git as main revision system as it seems to work out for the better for other projects.

Posted on: 5/14 9:23
Transfer the post to other applications Transfer


Re: Bounty system

Joined:
2016/8/9 0:17
From Sweden
Group:
Member
Posts: 27
Offline
Quote:

Kalamatee wrote:
You are aware there is a git mirror of the repo yes? The reason we have stuck with svn is because any of the other versioning tools developers ‘prefer to use’ support accessing svn, however they do not support each other.


I am aware of the git mirror, but you can't really do pull requests to a mirror, right? Which completely defeats the purpose of git. Or does the mirror work both ways?

Posted on: 5/14 8:52
Transfer the post to other applications Transfer


Re: Bounty system

Joined:
2016/8/9 0:17
From Sweden
Group:
Member
Posts: 27
Offline
I believe that the biggest hurdle to attract new developers is that it's very hard to get started. I've heard of people wanting to help applying but never get any response.

I believe using git + github would make it easier for new people to make contributions to the project as a whole. I understand it's not an easy task to just move over from Subversion, since most developers on the project already knows how to use this.

As it is, the project is pretty locked down.

Another "clone OS" decided to move from SVN to Git recently, ReactOS: https://www.reactos.org/project-news/r ... epository-migrated-github

They decided that this is the best way forward to "greatly improve the way we collaborate on development and reduce the barriers for newcomers".

That's just my opinion though, but I think the developers of AROS should consider this as a way to move forward with the project and possibly attract more developers in the process.



Posted on: 5/14 3:33

Edited by Marlon on 2018/5/14 4:04:17
Transfer the post to other applications Transfer


Re: Error linking binary - Milkytracker for AROS ABI-v1

Joined:
2016/8/9 0:17
From Sweden
Group:
Member
Posts: 27
Offline
Quote:

wawa wrote:
also im curious how do you get around these pragmas. perhaps bebbo has implemented something genuine gcc doesnt have in this form. yet strange as it isnt amiga specific.

Huh? I've done nothing special to get around any pragmas. Everything I've done is available in the premake4.lua file, I've done nothing else except from that. :)

Bebbo added some code in the premake-file to automatically detect the gcc6 toolchain for amigaos3.x, I wonder if we could do something similar in CMake?

Posted on: 5/14 3:08
Transfer the post to other applications Transfer


Re: Error linking binary - Milkytracker for AROS ABI-v1

Joined:
2016/8/9 0:17
From Sweden
Group:
Member
Posts: 27
Offline
I constantly make pull requests from the main upstream Milkytracker repo to keep the AmigaPorts one up to date. Your work on the CMakeFiles puts us on the path of a possible pull request to the main Milkytracker repo. I'm not sure how happy they will be with me reintroducing SDL-1.2 code into the main repo, but I noticed that a lot of the code between SDL-1.2 and SDL-2 was minimal and only required some ifdef's to keep it going.

I am however taking baby steps with this, and the main reason for me to use premake is to easily try stuff with multiple cross compilers (as I only work with cross compilers, no native compiles)

Posted on: 5/12 13:36
Transfer the post to other applications Transfer


Re: Error linking binary - Milkytracker for AROS ABI-v1

Joined:
2016/8/9 0:17
From Sweden
Group:
Member
Posts: 27
Offline
https://github.com/AmigaPorts/MilkyTracker/pull/11

Done! So much easier to review than a patch-file! =)

Posted on: 5/12 13:32
Transfer the post to other applications Transfer


Re: Error linking binary - Milkytracker for AROS ABI-v1

Joined:
2016/8/9 0:17
From Sweden
Group:
Member
Posts: 27
Offline
Quote:

wawa wrote:
what i mean is that a better option is if forks are not spread all around the world for users to investigate and thereore would be best to keep it common where possible. but thx. looking into it.

That's what pull requests are for.

Posted on: 5/12 6:42
Transfer the post to other applications Transfer


Re: Error linking binary - Milkytracker for AROS ABI-v1

Joined:
2016/8/9 0:17
From Sweden
Group:
Member
Posts: 27
Offline
Quote:

wawa wrote:
Quote:

Marlon wrote:
All Amiga based fixes in my Milkytracker source falls under the define __AMIGA__ and AMIGA. And I add define AROS and __AROS__ to that for AROS specific code.

One does not exclude the other.


in cmake files its AROS, like in "if(AROS)" otherwise you are right. we can probably simplify joining AROS and AMIGA where possible. i didnt want to change too much at this point. the changes in cmakelists shouldnt affect your way of compiling. but isnt that more convenient to simply use cmake with my changes and have it compile in one go?

My long term plan is to sort out the CMake support for all platforms. My initial fixes on Milkytracker was under the __AMIGA__ define. However as more work was made there's lines of code like:
#if defined(__AMIGA__) && !defined(AROS)

And also nested ones. it'll certainly break for an AROS compile if you don't define AMIGA and __AMIGA__ alongside AROS and __AROS__.

Quote:

configuration "i386-aros"
buildoptions "-O3 -fomit-frame-pointer -fno-exceptions -static-libstdc++ -s"
linkoptions { "-lpthread", "-static-libstdc++" }
includedirs { "/opt/x86-aros/bin/linux-i386/AROS/Extras/Developer/include", "/opt/x86-aros/bin/linux-x86_64/tools/crosstools/lib/gcc/i386-aros/6.3.0/include-fixed", "/opt/aros/sdk/include/SDL", "./src/ppui/osinterface/amiga", "./src/ppui/osinterface/sdl-1.2", "./src/ppui/osinterface/posix" }
libdirs { "" }
defines { "AMIGA", "__AMIGA__", "AROS", "aros", "__AROS__", "__aros__" }


I suggest you make a fork of the code, push it to your repo and do a pull request to the AmigaPorts repo. It's more work using the patch-files.

Posted on: 5/11 11:55
Transfer the post to other applications Transfer


Re: Error linking binary - Milkytracker for AROS ABI-v1

Joined:
2016/8/9 0:17
From Sweden
Group:
Member
Posts: 27
Offline
Quote:

wawa wrote:
Quote:

Marlon wrote:
And there's a reason I use premake instead of cmake... Cmake relies in SDL2. I made lots of edits to the source to keep the SDL1.2 compatibility, and CMake does not account for that at all.


not necessarily. look at my cmakelist.txt changes in main directory. you can disable sdl2 check. you jjust need to provide the link liib when necessary. also look at the other cmakelists changes around the source. im definitely including your sdl-1.2 headers and linking against aros sdl 1.2 library. there is no 2.0.

yes i have noticed the ahi code is based on sdl and not ready. im using the sdl of course.


All I'm saying is that I've personally done no changes to CMakeList.txt to accommodate for any of my changes. And even if you compile for AROS you need to define AMIGA (same goes for os4, morphos, warpos etc).

And my premake code accommodates for all that.

Posted on: 5/11 11:44
Transfer the post to other applications Transfer



 Top
(1) 2 3 »




Search
Top Posters
1 paolone
paolone
4426
2 magorium
magorium
4095
3 nikolaos
nikolaos
4009
4 phoenixkonsole
phoenixkonsole
3920
5 deadwood
deadwood
2917
6 ncafferkey
ncafferkey
2794
7 mazze
mazze
2221
8 clusteruk
clusteruk
2112
9 damocles
damocles
1789
10 BSzili
BSzili
1511
© 2004-2018 AROS Exec